[PATCH] D74784: [driver][darwin] Don't use -platform_version flag by default

[dmajor via Phabricator via cfe-commits]

dmajor added a comment.

In D74784#1882974 <https://reviews.llvm.org/D74784#1882974>, @steven_wu wrote:

> I forgot if there is reason to use the option by default at all time (I did ask that in the previous review but Alex might have given more context offline).


I would really like to hear from @arphaman, but they haven't responded to anything since I filed PR44813 nearly two weeks ago. Do you have any means to contact them?

> You should definitely add test for this change. The fact that you change all `-mlinker-version=400` to `-mlinker-version=0` but not change any CHECK lines means the change is definitely not tested :)

Can you elaborate on what you would like to see tested? I thought I _was_ updating the tests to match the code. The `-mlinker-version=0` lines check that we now use the old behavior by default, and the existing `-mlinker-version=520` lines in e.g. `darwin-ld-platform-version-macos.c` test that we still use the new behavior when requested.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74784/new/

https://reviews.llvm.org/D74784