[PATCH] D74784: [driver][darwin] Don't use -platform_version flag by default

Steven Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 19 09:40:58 PST 2020


steven_wu added a comment.

I forgot if there is reason to use the option by default at all time (I did ask that in the previous review but Alex might have given more context offline).

You should definitely add test for this change. The fact that you change all `-mlinker-version=400` to `-mlinker-version=0` but not change any CHECK lines means the change is definitely not tested :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74784/new/

https://reviews.llvm.org/D74784





More information about the cfe-commits mailing list