[PATCH] D71222: Include Stmt.h where it seems to be necessary for modules builds

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 9 13:12:04 PST 2019


rnk created this revision.
rnk added a reviewer: rdhindsa.
Herald added a project: clang.
rdhindsa accepted this revision.
rdhindsa added a comment.
This revision is now accepted and ready to land.

LGTM


After 60573ae6fe50 <https://reviews.llvm.org/rG60573ae6fe509b618dc6a2c5c55d921bccd77608> removed an include of Expr.h from ASTContext.h, this
header fails to compile in some modular build configurations. I have not
been able to reproduce the problem locally. The header compiles fine in
isolation. However, based on reading the code, it seems like it would
require Stmt to be complete. Based on that intuition, we decided to add the
include.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D71222

Files:
  clang/include/clang/Tooling/Refactoring/ASTSelection.h


Index: clang/include/clang/Tooling/Refactoring/ASTSelection.h
===================================================================
--- clang/include/clang/Tooling/Refactoring/ASTSelection.h
+++ clang/include/clang/Tooling/Refactoring/ASTSelection.h
@@ -10,6 +10,7 @@
 #define LLVM_CLANG_TOOLING_REFACTOR_AST_SELECTION_H
 
 #include "clang/AST/ASTTypeTraits.h"
+#include "clang/AST/Stmt.h"
 #include "clang/Basic/LLVM.h"
 #include "clang/Basic/SourceLocation.h"
 #include <vector>


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D71222.232919.patch
Type: text/x-patch
Size: 479 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20191209/fa10d999/attachment.bin>


More information about the cfe-commits mailing list