[clang] 1164d43 - Include Stmt.h where it seems to be necessary for modules builds

Reid Kleckner via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 9 13:09:18 PST 2019


Author: Reid Kleckner
Date: 2019-12-09T13:08:44-08:00
New Revision: 1164d43855fd5b58fde221445ab0e407c0bd92ee

URL: https://github.com/llvm/llvm-project/commit/1164d43855fd5b58fde221445ab0e407c0bd92ee
DIFF: https://github.com/llvm/llvm-project/commit/1164d43855fd5b58fde221445ab0e407c0bd92ee.diff

LOG: Include Stmt.h where it seems to be necessary for modules builds

Summary:
After 60573ae6fe50 removed an include of Expr.h from ASTContext.h, this
header fails to compile in some modular build configurations. I have not
been able to reproduce the problem locally. The header compiles fine in
isolation. However, based on reading the code, it seems like it would
require Stmt to be complete. Based on that intuition, we decided to add the
include.

Reviewers: rdhindsa

Subscribers: cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D71222

Added: 
    

Modified: 
    clang/include/clang/Tooling/Refactoring/ASTSelection.h

Removed: 
    


################################################################################
diff  --git a/clang/include/clang/Tooling/Refactoring/ASTSelection.h b/clang/include/clang/Tooling/Refactoring/ASTSelection.h
index b87ed28b30ad..9122b5c73c98 100644
--- a/clang/include/clang/Tooling/Refactoring/ASTSelection.h
+++ b/clang/include/clang/Tooling/Refactoring/ASTSelection.h
@@ -10,6 +10,7 @@
 #define LLVM_CLANG_TOOLING_REFACTOR_AST_SELECTION_H
 
 #include "clang/AST/ASTTypeTraits.h"
+#include "clang/AST/Stmt.h"
 #include "clang/Basic/LLVM.h"
 #include "clang/Basic/SourceLocation.h"
 #include <vector>


        


More information about the cfe-commits mailing list