[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

Wed Oct 9 08:17:03 PDT 2019

nridge added a comment.

In D67536#1701038 <https://reviews.llvm.org/D67536#1701038>, @ilya-biryukov wrote:

> In D67536#1700872 <https://reviews.llvm.org/D67536#1700872>, @nridge wrote:
>
> > > It also lets them consistently highlight part of the line (e.g. dead expressions or statements can be marked in gray even if they are on the same line).
> >
> > Highlighting part of a line is not applicable to inactive preprocessor branches in C++.
>
>
> Note that the opposite is true - inactive preprocessor branches can be expressed as range-based highlightings.

Except that if we want to allow background styling, the client would need to special-case the highlighting scope to know to apply the background style to the entire line.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67536/new/

https://reviews.llvm.org/D67536