[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 9 03:33:03 PDT 2019


ilya-biryukov added a comment.

Just noticed the next version of LSP added diagnostic tags for things like "unused field" or "dead code":
https://microsoft.github.io/language-server-protocol/specifications/specification-3-15, search for `DiagnosticTag`.

So I guess we won't need ever add range-based highlightings for dead code (and similar), we'll use diagnostics instead.

Concerns about having two kinds of highlightings to handle on the clients are still there, though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67536/new/

https://reviews.llvm.org/D67536





More information about the cfe-commits mailing list