[PATCH] D27165: Add format_dynamic_key_arg attribute to improve "-Wformat" warnings for functions that load the formatting string dynamically based on a key value
Aaron Ballman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Aug 14 08:36:53 PDT 2019
aaron.ballman accepted this revision.
aaron.ballman added a comment.
I like this approach much better! LGTM, aside from a minor nit.
Comment at: clang/include/clang/Basic/IdentifierTable.h:754
+ /// If this selector is the specific keyword selector described by Names.
+ bool isKeywordSelector(ArrayRef<StringRef> Names);
> Thanks. Could you go ahead and add `isUnarySelector(StringRef)` for consistency?
Also, the function should be marked `const`, I would imagine.
CHANGES SINCE LAST ACTION
More information about the cfe-commits