[PATCH] D27165: Add format_dynamic_key_arg attribute to improve "-Wformat" warnings for functions that load the formatting string dynamically based on a key value
John McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Aug 13 16:58:02 PDT 2019
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
One minor request (which will be dead code in your patch), but otherwise LGTM.
Comment at: clang/include/clang/Basic/IdentifierTable.h:754
+ /// If this selector is the specific keyword selector described by Names.
+ bool isKeywordSelector(ArrayRef<StringRef> Names);
Thanks. Could you go ahead and add `isUnarySelector(StringRef)` for consistency?
CHANGES SINCE LAST ACTION
More information about the cfe-commits