[PATCH] D66211: [clangd][vscode] Surface the error when applying tweaks fails
Ilya Biryukov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Aug 14 05:56:14 PDT 2019
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
Thanks for providing examples of error messages, also agree they look fine.
If we find bad error messages later, we could revisit the presentation strategy.
Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts:109
+ // Keep the default behavior.
+ if (error instanceof vscodelc.ResponseError &&
+ error.code === vscodelc.ErrorCodes.RequestCancelled)
Is this how default implementation behaves? Is there a way to call into it instead of re-implementing?
If so, it would be nice to do so. If not, I'm also ok if we keep it.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits