[PATCH] D66211: [clangd][vscode] Surface the error when applying tweaks fails
Haojian Wu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Aug 14 05:45:24 PDT 2019
hokein added a comment.
In D66211#1629112 <https://reviews.llvm.org/D66211#1629112>, @ilya-biryukov wrote:
> How do they look in practice? In particular, should we add more context information (either in clangd or in the VSCode extension) to those errors, now that we know they are shown to the users?
> Something like `Failed to apply a fix: input range is invalid` vs `input range is invalid`.
I don't have a very strong preference on adding more context, the current messages seem good enough to me, something like:
- "edits were not applied: <reason>"
- "Could not expand type of lambda expression:"
- "Could not obtain range of the 'else' branch. Macros?"
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits