[clang-tools-extra] r367406 - [Clangd] NFC: Added FIXME in ExtractVariable tests

Shaurya Gupta via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 31 03:08:29 PDT 2019


Author: sureyeaah
Date: Wed Jul 31 03:08:29 2019
New Revision: 367406

URL: http://llvm.org/viewvc/llvm-project?rev=367406&view=rev
Log:
[Clangd] NFC: Added FIXME in ExtractVariable tests

Modified:
    clang-tools-extra/trunk/clangd/unittests/TweakTests.cpp

Modified: clang-tools-extra/trunk/clangd/unittests/TweakTests.cpp
URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clangd/unittests/TweakTests.cpp?rev=367406&r1=367405&r2=367406&view=diff
==============================================================================
--- clang-tools-extra/trunk/clangd/unittests/TweakTests.cpp (original)
+++ clang-tools-extra/trunk/clangd/unittests/TweakTests.cpp Wed Jul 31 03:08:29 2019
@@ -419,6 +419,11 @@ TEST(TweakTest, ExtractVariable) {
                  void f(int a) {
                    PLUS([[1+a]]);
                  })cpp",
+          /*FIXME: It should be extracted like this.
+           R"cpp(#define PLUS(x) x++
+                 void f(int a) {
+                   auto dummy = 1+a; int y = PLUS(dummy);
+                 })cpp"},*/
            R"cpp(#define PLUS(x) x++
                  void f(int a) {
                    auto dummy = PLUS(1+a); dummy;
@@ -429,9 +434,9 @@ TEST(TweakTest, ExtractVariable) {
                    if(1)
                     LOOP(5 + [[3]])
                  })cpp",
-           /*FIXME: It should be extracted like this. SelectionTree needs to be
+          /*FIXME: It should be extracted like this. SelectionTree needs to be
             * fixed for macros.
-         R"cpp(#define LOOP(x) while (1) {a = x;}
+           R"cpp(#define LOOP(x) while (1) {a = x;}
                void f(int a) {
                  auto dummy = 3; if(1)
                   LOOP(5 + dummy)




More information about the cfe-commits mailing list