[PATCH] D64838: [Attr] Support _attribute__ ((fallthrough))

Dávid Bolvanský via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jul 28 11:13:44 PDT 2019


xbolva00 added inline comments.


================
Comment at: clang/lib/Sema/AnalysisBasedWarnings.cpp:1228
+  if (MacroName.empty()) {
+    if (!PreferClangAttr)
+      MacroName = "[[fallthrough]]";
----------------
This code is not tested?

I think you can use tests from my older patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64838/new/

https://reviews.llvm.org/D64838





More information about the cfe-commits mailing list