[PATCH] D64838: [Attr] Support _attribute__ ((fallthrough))

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added inline comments.


================
Comment at: clang/lib/Parse/ParseStmt.cpp:103
   MaybeParseCXX11Attributes(Attrs, nullptr, /*MightBeObjCMessageSend*/ true);
+
   if (!MaybeParseOpenCLUnrollHintAttribute(Attrs))
----------------
Spurious newline?


================
Comment at: clang/lib/Parse/ParseStmt.cpp:218
                                              DeclEnd, Attrs);
+      if (SeenGNUAttributes) {
+        DeclStart = GNUAttributeLoc;
----------------
Elide braces.


================
Comment at: clang/lib/Sema/AnalysisBasedWarnings.cpp:1279
         continue;
-      if (S.getLangOpts().CPlusPlus11) {
+      if (S.getLangOpts().CPlusPlus11 || S.getLangOpts().C99) {
         const Stmt *Term = B->getTerminatorStmt();
----------------
What is special about C99 here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64838/new/

https://reviews.llvm.org/D64838