[PATCH] D64780: Disallow most calling convention attributes on PS4.

Warren Ristow via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 19 11:14:12 PDT 2019


wristow accepted this revision.
wristow added a comment.

In D64780#1593624 <https://reviews.llvm.org/D64780#1593624>, @aaron.ballman wrote:

> LGTM aside from a nit. You should give other reviewers a chance to sign off in case they have additional comments.


LGTM too, once the line-length is fixed (and IMO, no need to update the review for just that line-length change).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64780/new/

https://reviews.llvm.org/D64780





More information about the cfe-commits mailing list