[PATCH] D64780: Disallow most calling convention attributes on PS4.

Sunil Srivastava via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 19 09:46:28 PDT 2019


Sunil_Srivastava marked an inline comment as done.
Sunil_Srivastava added inline comments.


================
Comment at: lib/Basic/Targets/OSTargets.h:564
   }
+  TargetInfo::CallingConvCheckResult checkCallingConvention(CallingConv CC) const override {
+    return (CC == CC_C) ? TargetInfo::CCCR_OK : TargetInfo::CCCR_Error;
----------------
aaron.ballman wrote:
> Line length seems a bit long for coding style requirements.
Ooops. You are right. Will split according to clang-format. Would you want me to update the review?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64780/new/

https://reviews.llvm.org/D64780





More information about the cfe-commits mailing list