[PATCH] D64799: [Sema] Emit diagnostics for uncorrected delayed typos at the end of TU

Richard Smith - zygoloid via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 17 22:11:24 PDT 2019

rsmith added a comment.

In D64799#1589557 <https://reviews.llvm.org/D64799#1589557>, @ilya-biryukov wrote:

> I tried to find a good place to emit unresolved typos earlier (to make sure CodeGen does not ever get `TypoExpr`), but couldn't find one.
>  Please let me know if there's some obvious place I'm missing.

The original plan when we were first designing the feature was to emit these diagnostics when we pop an expression evaluation context. Maybe we could try that? If there's a reason to defer typo correction across such contexts, it might probably be rare enough that we can explicitly handle that and manually move the delayed typos to the surrounding context.

> unless people object I would propose to land it even if it does not solve all of the problems around delayed exprs.

Sounds good to me.

  rG LLVM Github Monorepo



More information about the cfe-commits mailing list