[PATCH] D64799: [Sema] Emit diagnostics for uncorrected delayed typos at the end of TU

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 17 08:49:49 PDT 2019


sammccall added a comment.

Big +1 from me, though I can't say I understand this well enough to substitute for Richard here.



================
Comment at: clang/lib/Sema/Sema.cpp:916
+  // cases in practice.
+  for (const auto &Typo : DelayedTypos) {
+    // We pass an empty TypoCorrection to indicate no correction was performed.
----------------
If you like, `DEBUG_WITH_TYPE("DelayedTypos", ...)` would still let people who want to fix these see them. In practice, I suspect nobody actually wants to fix these, though :-(


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64799/new/

https://reviews.llvm.org/D64799





More information about the cfe-commits mailing list