[PATCH] D64383: build: use multiple `install` rather than building up a list

Tue Jul 9 07:49:51 PDT 2019

ldionne added a comment.

I like that. Almost anything that helps us abolish global variables and lists (here `LIBCXX_INSTALL_TARGETS`) in the CMake scripts is a good thing.

================
Comment at: src/CMakeLists.txt:441
+  if (LIBCXX_INSTALL_STATIC_LIBRARY)
+    install(TARGETS cxx_static
+      ARCHIVE DESTINATION ${LIBCXX_INSTALL_PREFIX}${LIBCXX_INSTALL_LIBRARY_DIR} COMPONENT cxx
----------------
Just to double-check, it's redundant to say `ARCHIVE` here because CMake knows it's a static archive -- correct?

Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64383/new/

https://reviews.llvm.org/D64383