[PATCH] D64383: build: use multiple `install` rather than building up a list

Saleem Abdulrasool via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 9 08:02:40 PDT 2019


compnerd marked an inline comment as done.
compnerd added a comment.

@ldionne - that was exactly the motivation for this change - it always takes me a couple of reads to figure out what we are trying to do here.



================
Comment at: src/CMakeLists.txt:441
+  if (LIBCXX_INSTALL_STATIC_LIBRARY)
+    install(TARGETS cxx_static
+      ARCHIVE DESTINATION ${LIBCXX_INSTALL_PREFIX}${LIBCXX_INSTALL_LIBRARY_DIR} COMPONENT cxx
----------------
ldionne wrote:
> Just to double-check, it's redundant to say `ARCHIVE` here because CMake knows it's a static archive -- correct?
No, the `ARCHIVE DESTINATION` here indicates to CMake where to install the target *if* it is an archive.  This is the location used if the target is a static library or if the target is Windows and the target is a shared library in which case this is the path where the import library is installed.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64383/new/

https://reviews.llvm.org/D64383





More information about the cfe-commits mailing list