[PATCH] D62580: [OpenCL] Use long instead of long long in x86 builtins

[Craig Topper via Phabricator via cfe-commits]

craig.topper added inline comments.


================
Comment at: clang/lib/AST/ASTContext.cpp:9308
     case 'L':
       assert(!IsSpecial && "Can't use 'L' with 'W', 'N' or 'Z' modifiers");
       assert(HowLong <= 2 && "Can't have LLLL modifier");
----------------
O should be mentioned here


================
Comment at: clang/lib/AST/ASTContext.cpp:9314
       // 'N' behaves like 'L' for all non LP64 targets and 'int' otherwise.
       assert(!IsSpecial && "Can't use two 'N', 'W' or 'Z' modifiers!");
       assert(HowLong == 0 && "Can't use both 'L' and 'N' modifiers!");
----------------
O should be mentioned here


================
Comment at: clang/lib/AST/ASTContext.cpp:9324
       // This modifier represents int64 type.
       assert(!IsSpecial && "Can't use two 'N', 'W' or 'Z'  modifiers!");
       assert(HowLong == 0 && "Can't use both 'L' and 'W' modifiers!");
----------------
O should be mentioned here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62580/new/

https://reviews.llvm.org/D62580