[PATCH] D62580: [OpenCL] Use long instead of long long in x86 builtins
Craig Topper via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed May 29 10:36:23 PDT 2019
craig.topper added a comment.
In D62580#1521277 <https://reviews.llvm.org/D62580#1521277>, @erichkeane wrote:
> A different (perhaps silly) question is why 'W' isn't sufficient? It represents int64_t, which I wonder if is sufficient.
I had asked in a separate conversation not to change the signatures outside of opencl. I believe W would use 'long' on 64-bit targets that aren't Windows or X32. The builtins are defined by gcc as well so I wanted to avoid making them different as much as possible.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits