[PATCH] D61509: [OpenMP] Set pragma start loc to `#pragma` loc

[Joel E. Denny via Phabricator via cfe-commits]

jdenny added a comment.

In D61509#1512294 <https://reviews.llvm.org/D61509#1512294>, @ABataev wrote:

> In D61509#1512293 <https://reviews.llvm.org/D61509#1512293>, @Meinersbur wrote:
>
> > 1. Is there a diagnostic that would point to the `omp` token? As much as I like complete info (such as SourceLoc of semicolons), I cannot think of a use case for it.
> > 2. I would like to see all of them all adjusted. There is an immediate improvement in that improves the diagnostic output.
>
>
>
>
> 1. Nope, there is no `omp` specific diagnostics




1. Based on the test suite changes this patch makes, I agree for OpenMP.  I haven't explored other pragmas.

2. I too think it likely makes sense to adjust them all eventually.  But do people think it's important to write patches adjusting all pragmas before pushing the adjustment for any of them?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61509/new/

https://reviews.llvm.org/D61509