[PATCH] D61509: [OpenMP] Set pragma start loc to `#pragma` loc

Michael Kruse via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 22 09:33:05 PDT 2019


Meinersbur added a comment.

In D61509#1512311 <https://reviews.llvm.org/D61509#1512311>, @jdenny wrote:

> 2. I too think it likely makes sense to adjust them all eventually.  But do people think it's important to write patches adjusting all pragmas before pushing the adjustment for any of them?


I am not sure I understand. Do you mean whether you need all patches for each pragma to be accepted before you can commit the first? This is not that case. IMHO you can even put all of it into a single patch as it should be very straightforward. The most work is adapting the tests.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61509/new/

https://reviews.llvm.org/D61509





More information about the cfe-commits mailing list