[PATCH] D61121: [Windows] Separate elements in -print-search-dirs with semicolons
Reid Kleckner via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Apr 25 10:34:10 PDT 2019
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
In D61121#1479031 <https://reviews.llvm.org/D61121#1479031>, @smeenai wrote:
> I feel something like `llvm::sys::path::PathListSeparator` would be nicer, since AFAIK any path list should be separated with semicolons on Windows and colons everywhere else.
I think the dominant use case for `EnvPathSeparator` is separating a list of paths in environment variables. We have other use cases for it in lists of paths that aren't environment variables (-print-search-dirs), but renaming it just seems like a minor improvement, which seems like it should be separate from this change.
CHANGES SINCE LAST ACTION
More information about the cfe-commits