[PATCH] D61121: [Windows] Separate elements in -print-search-dirs with semicolons
Reid Kleckner via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Apr 25 10:33:18 PDT 2019
rnk added a comment.
> Alternatively, this could just be a local ifdef _WIN32 in this function, or should we generalize the existing EnvPathSeparator to e.g. a llvm::sys::path::PathListSeparator?
I think it's clear as is. We're just reusing the environment path separator, which is used for INCLUDE, LIBS, PATH, and other path list environment variables.
> Does this change need a test?
If we don't already have tests for the colon separator, I don't think we need new tests to verify we get `:` on posix and `;` on Windows.
CHANGES SINCE LAST ACTION
More information about the cfe-commits