[PATCH] D59195: [analyzer] Remove the default value arg from getChecker*Option

Artem Dergachev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 25 14:28:45 PDT 2019


NoQ accepted this revision.
NoQ added inline comments.


================
Comment at: lib/StaticAnalyzer/Core/AnalyzerOptions.cpp:148-150
+  assert(Ret &&
+         "This option should be either 'true' or 'false', and should've been "
+         "validated by CheckerRegisrty!");
----------------
Even though `operator*()` would have asserted that there's a value, i really appreciate the user-friendly assert message.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59195/new/

https://reviews.llvm.org/D59195





More information about the cfe-commits mailing list