[PATCH] D59195: [analyzer] Remove the default value arg from getChecker*Option

[Reka Kovacs via Phabricator via cfe-commits]

rnkovacs added inline comments.


================
Comment at: lib/StaticAnalyzer/Core/AnalyzerOptions.cpp:148-150
+  assert(Ret &&
+         "This option should be either 'true' or 'false', and should've been "
+         "validated by CheckerRegisrty!");
----------------
NoQ wrote:
> Even though `operator*()` would have asserted that there's a value, i really appreciate the user-friendly assert message.
Sorry for the impertinence, but there's a typo: `CheckerRegisrty`.


================
Comment at: lib/StaticAnalyzer/Core/AnalyzerOptions.cpp:171
+         "This option should be numeric, and should've been validated by "
+         "CheckerRegisrty!");
   (void)HasFailed;
----------------
And the same typo here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59195/new/

https://reviews.llvm.org/D59195