[PATCH] D57874: [WebAssembly] Set '-matomics' when '-pthread' is set

Heejin Ahn via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 7 16:57:14 PST 2019


aheejin marked an inline comment as done.
aheejin added inline comments.


================
Comment at: lib/Driver/ToolChains/WebAssembly.cpp:66
+    if (Args.hasFlag(clang::driver::options::OPT_pthread,
+                     clang::driver::options::OPT_no_pthread),
+        false)
----------------
This code is not strictly related, but `hasFlag` is better than `hasArg` when there are both positive and negative versions of an option exist.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57874/new/

https://reviews.llvm.org/D57874





More information about the cfe-commits mailing list