[PATCH] D57874: [WebAssembly] Set '-matomics' when '-pthread' is set
Heejin Ahn via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Feb 7 16:55:00 PST 2019
aheejin updated this revision to Diff 185895.
aheejin added a comment.
Sorry nevermind my previous code. There was not hacky and much cleaner way to do everything in the driver layer. (Before I tried to do everything in the cc1 compilation layer :( )
Anyway, moved all logic to the driver layer and did this:
- `-matomics` means `-mthread-model posix`
- `-mthread-model posix` means `-matomics`
- `-pthread` means both `-matomics` and `-mthread-model posix`
It currently does not check mismatches and crash. If either of `-matomics` or `-mthread-model posix` is set it is gonna set both. THe same for `-pthread`. Not sure which flag is the *canonical* one to trust.
CHANGES SINCE LAST ACTION
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 7151 bytes
Desc: not available
More information about the cfe-commits