[PATCH] D56943: [clang-format][NFC] Allow getLLVMStyle() to take a language

Jordan Rupprecht via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 7 08:59:02 PST 2019

rupprecht added a comment.

In D56943#1388985 <https://reviews.llvm.org/D56943#1388985>, @rupprecht wrote:

> In D56943#1388314 <https://reviews.llvm.org/D56943#1388314>, @kristina wrote:
> > The patch itself looks sound. However given that you have a specific use case in mind (TableGen files) could you provide supplementary coverage for that specific use case (unit tests for formatting `td` syntax using `format::getLLVMStyle(format::FormatStyle::LK_TableGen)`? I'm not entirely sure how useful this particular change is given that there's no linked patches related to your use case, I think adding those would help as well (possibly as a separate dependent patchset).
> The use case is a pre-refactoring for D55964 <https://reviews.llvm.org/D55964>, which is in the patch description -- is that what you mean by "linked patches"?
>  I'll update that patch to use this approach, and make it a dependent patch.

Added as a dependent patch. I've never linked patches together, so I might not be doing it right. Guess I'll read some phab docs now...

  rC Clang



More information about the cfe-commits mailing list