[PATCH] D57739: [clangd] Format tweak's replacements.
Ilya Biryukov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Feb 6 05:08:57 PST 2019
ilya-biryukov added inline comments.
Comment at: clangd/refactor/Tweak.h:56
+ /// The style to format generated changes.
+ format::FormatStyle Style;
NIT: Maybe make this a second argument of `apply`?
This would convey the idea that `execute()` should not do formatting on its own.
Comment at: clangd/refactor/Tweak.h:72
+ /// action.
+ Expected<tooling::Replacements> apply(const Selection &Sel);
/// A one-line title of the action that should be shown to the users in the
Could you duplicate the `EXPECTS:` comments here? It's an important part of the public API.
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
More information about the cfe-commits