[PATCH] D57739: [clangd] Format tweak's replacements.

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 6 05:25:09 PST 2019


ilya-biryukov added inline comments.


================
Comment at: clangd/refactor/Tweak.h:81
+  /// EXPECTS: prepare() was called and returned true.
+  virtual Expected<tooling::Replacements> execute(const Selection &Sel) = 0;
 };
----------------
hokein wrote:
> I think the current name is slightly better than `doApply`, I also have a few candidates in mind `perform`, `invoke`.
`execute()` LGTM!


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57739/new/

https://reviews.llvm.org/D57739





More information about the cfe-commits mailing list