[libcxx] r333325 - Add nonnull; use it for atomics

JF Bastien via cfe-commits cfe-commits at lists.llvm.org
Sat May 26 12:50:19 PDT 2018

> On May 26, 2018, at 12:36 PM, Marshall Clow <mclow.lists at gmail.com> wrote:
> On Fri, May 25, 2018 at 4:43 PM, JF Bastien via cfe-commits <cfe-commits at lists.llvm.org <mailto:cfe-commits at lists.llvm.org>> wrote:
> Author: jfb
> Date: Fri May 25 16:43:53 2018
> New Revision: 333325
> URL: http://llvm.org/viewvc/llvm-project?rev=333325&view=rev <http://llvm.org/viewvc/llvm-project?rev=333325&view=rev>
> Log:
> Add nonnull; use it for atomics
> JF - please revert this patch.


> Let's have a discussion about how to implement this so that it is more friendly to people with installed code bases.
> [ We've had *extremely* loud responses to unilaterally adding warnings - especially ones that can't be easily disabled - to the libc++ code base in the past. ] 

Ha! Interesting point which I hadn’t considered. I guess the clang warning can be controlled, but this one cannot? Agreed that’s suboptimal and we should figure out a way to make them controllable.

> Also, please include both myself and EricWF on all libc++ reviews.

Sorry, will do. I assumed you’d all have Herald auto-add if you wanted to be on a patch :-)

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180526/088212f2/attachment.html>

More information about the cfe-commits mailing list