[libcxx] r333325 - Add nonnull; use it for atomics

Marshall Clow via cfe-commits cfe-commits at lists.llvm.org
Sat May 26 12:36:24 PDT 2018


On Fri, May 25, 2018 at 4:43 PM, JF Bastien via cfe-commits <
cfe-commits at lists.llvm.org> wrote:

> Author: jfb
> Date: Fri May 25 16:43:53 2018
> New Revision: 333325
>
> URL: http://llvm.org/viewvc/llvm-project?rev=333325&view=rev
> Log:
> Add nonnull; use it for atomics
>
>
JF - please revert this patch.
Let's have a discussion about how to implement this so that it is more
friendly to people with installed code bases.
[ We've had *extremely* loud responses to unilaterally adding warnings -
especially ones that can't be easily disabled - to the libc++ code base in
the past. ]

Also, please include both myself and EricWF on all libc++ reviews.

-- Marshall
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180526/cb56951c/attachment.html>


More information about the cfe-commits mailing list