<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On May 26, 2018, at 12:36 PM, Marshall Clow <<a href="mailto:mclow.lists@gmail.com" class="">mclow.lists@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><br class=""><div class="gmail_extra"><br class=""><div class="gmail_quote">On Fri, May 25, 2018 at 4:43 PM, JF Bastien via cfe-commits <span dir="ltr" class=""><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank" class="">cfe-commits@lists.llvm.org</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: jfb<br class="">
Date: Fri May 25 16:43:53 2018<br class="">
New Revision: 333325<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=333325&view=rev" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-<wbr class="">project?rev=333325&view=rev</a><br class="">
Log:<br class="">
Add nonnull; use it for atomics<br class=""><br class=""></blockquote><div class=""><br class=""></div><div class="">JF - please revert this patch.</div></div></div></div></div></blockquote><div><br class=""></div><div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: Menlo; background-color: rgb(255, 255, 255);" class=""><span style="font-variant-ligatures: no-common-ligatures" class="">r333351</span></div></div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><div class="">Let's have a discussion about how to implement this so that it is more friendly to people with installed code bases.</div><div class="">[ We've had *extremely* loud responses to unilaterally adding warnings - especially ones that can't be easily disabled - to the libc++ code base in the past. ] </div></div></div></div></div></blockquote><div><br class=""></div><div>Ha! Interesting point which I hadn’t considered. I guess the clang warning can be controlled, but this one cannot? Agreed that’s suboptimal and we should figure out a way to make them controllable.</div><div><br class=""></div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="gmail_extra">Also, please include both myself and EricWF on all libc++ reviews.</div></div></div></blockquote><br class=""></div><div>Sorry, will do. I assumed you’d all have Herald auto-add if you wanted to be on a patch :-)</div><div><br class=""></div><br class=""></body></html>