[PATCH] D26903: [libcxx] Add <variant> tests (but not implementation)

Casey Carter via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 22 16:57:24 PST 2016

CaseyCarter added inline comments.

Comment at: test/std/utilities/variant/variant.helpers/variant_alternative.pass.cpp:33
+void test() {
+    static_assert(std::is_same_v<
+        typename std::variant_alternative<I, V>::type, E>, "");
STL_MSFT wrote:
> EricWF wrote:
> > STL_MSFT wrote:
> > > You aren't directly including <type_traits> (not sure if "variant_test_helpers.hpp" is).
> > Fixing this. Does your `<variant>` somehow not drag in `<type_traits>`?
> Of course <variant> drags in <type_traits>, I'm just being nitpicky :-)
STL's internal compiler is well-known for being more strict than any shipping compiler.


More information about the cfe-commits mailing list