[PATCH] D26903: [libcxx] Add <variant> tests (but not implementation)

Eric Fiselier via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 22 17:03:13 PST 2016

EricWF marked an inline comment as done.
EricWF added inline comments.

Comment at: test/std/utilities/variant/variant.variant/variant.swap/swap.pass.cpp:487
+// This is why variant should SFINAE member hash. :-)
+template class std::variant<int, NotSwappable>;
CaseyCarter wrote:
> This instantiates `variant<int, NotSwappable>::swap` without meeting the requirements thereof (i.e., our member swap does not SFINAE).
Forgot to wrap that in a `LIBCPP_ONLY`. 


More information about the cfe-commits mailing list