[PATCH] D26903: [libcxx] Add <variant> tests (but not implementation)

Casey Carter via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 22 16:56:00 PST 2016


CaseyCarter added a comment.

Other than the note in variant.variant\variant.swap\swap.pass.cpp, all passes pass and all fails fail with out implementation.



================
Comment at: test/std/utilities/variant/variant.variant/variant.swap/swap.pass.cpp:487
+// This is why variant should SFINAE member hash. :-)
+template class std::variant<int, NotSwappable>;
+
----------------
This instantiates `variant<int, NotSwappable>::swap` without meeting the requirements thereof (i.e., our member swap does not SFINAE).


https://reviews.llvm.org/D26903





More information about the cfe-commits mailing list