[PATCH] D22774: [MSVC] Add ARM support to intrin.h for MSVC compatibility

Renato Golin via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 1 04:46:35 PDT 2016

rengolin added inline comments.

Comment at: lib/Headers/armintr.h:27
@@ +26,3 @@
+typedef enum
mstorsjo wrote:
> rengolin wrote:
> > Maybe an ifdef Windows wrapper, to make sure not to mess up *nix environments?
> I can add the same as at the top of intrin.h, i.e. this:
> ```
> /* Only include this if we're compiling for the windows platform. */
> #ifndef _MSC_VER
> #include_next <intrin.h>
> #else
> ```
Could be. I know you have that on the including header, but nothing stops people from including this one too by accident. Also, it makes it more clear where it should work and where it shouldn't.


More information about the cfe-commits mailing list