[PATCH] D22774: [MSVC] Add ARM support to intrin.h for MSVC compatibility

Martin Storsjö via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 1 05:01:11 PDT 2016

mstorsjo added inline comments.

Comment at: lib/Headers/armintr.h:27
@@ +26,3 @@
+typedef enum
rengolin wrote:
> mstorsjo wrote:
> > rengolin wrote:
> > > Maybe an ifdef Windows wrapper, to make sure not to mess up *nix environments?
> > I can add the same as at the top of intrin.h, i.e. this:
> > 
> > 
> > ```
> > /* Only include this if we're compiling for the windows platform. */
> > #ifndef _MSC_VER
> > #include_next <intrin.h>
> > #else
> > ```
> Could be. I know you have that on the including header, but nothing stops people from including this one too by accident. Also, it makes it more clear where it should work and where it shouldn't.
No, I meant just like you want, but instead of `#ifdef _WIN32` use `#ifndef _MSC_VER`, and use `#include_next <armintr.h>` for when not working in MSVC mode, i.e. behave as if our header didn't exist at all.

So I agree that it's useful to have on this individual header as well, not only rely on this guard in the intrin.h.


More information about the cfe-commits mailing list