[PATCH] D22774: [MSVC] Add ARM support to intrin.h for MSVC compatibility

Martin Storsjö via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 1 04:35:47 PDT 2016

mstorsjo added a comment.

In https://reviews.llvm.org/D22774#501993, @rengolin wrote:

> Can you add a test on test/Headers, like the others, please?

Sure, there seems to be a good spot for that in ms-intrin.cpp.

Comment at: lib/Headers/armintr.h:1
@@ +1,2 @@
+/*===---- armintr.h - ARM intrinsics ---------------------------------------===
+ *
rengolin wrote:
> Maybe a hint that this is "ARM Windows Intrinsics"?

Comment at: lib/Headers/armintr.h:27
@@ +26,3 @@
+typedef enum
rengolin wrote:
> Maybe an ifdef Windows wrapper, to make sure not to mess up *nix environments?
I can add the same as at the top of intrin.h, i.e. this:

/* Only include this if we're compiling for the windows platform. */
#ifndef _MSC_VER
#include_next <intrin.h>


More information about the cfe-commits mailing list