[PATCH] D20561: Warn when taking address of packed member

Roger Ferrer Ibanez via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 14 13:04:58 PDT 2016

Yes I will revert this ASAP.

Sorry for the fuss.

From: Aaron Ballman <aaron.ballman at gmail.com>
Sent: 14 July 2016 19:30:58
To: reviews+D20561+public+af1fea8a731d85ae at reviews.llvm.org
Cc: Roger Ferrer Ibanez; Richard Smith; James Y Knight; Evgenii Stepanov; cfe-commits
Subject: Re: [PATCH] D20561: Warn when taking address of packed member

Roger, can you please revert? This seems to have caused some pain for
our users, and it would be good to unblock them while deciding what to
do about the issues.


On Thu, Jul 14, 2016 at 2:19 PM, James Y Knight <jyknight at google.com> wrote:
> jyknight added a comment.
> Regardless, I think this should not have added a new un-disableable error, but instead only a default-on warning.
> The ""binding reference to packed member" error is firing on some of our code, and even if it's not a false-positive, it should be possible to disable it until the code is modified.
> Repository:
>   rL LLVM
> https://reviews.llvm.org/D20561

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160714/361f2ccc/attachment.html>

More information about the cfe-commits mailing list