<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Exchange Server">
<!-- converted from text --><style><!-- .EmailQuote { margin-left: 1pt; padding-left: 4pt; border-left: #800000 2px solid; } --></style>
</head>
<body>
<meta content="text/html; charset=UTF-8">
<style type="text/css" style="">
<!--
p
{margin-top:0;
margin-bottom:0}
-->
</style>
<div dir="ltr">
<div id="x_divtagdefaultwrapper" style="font-size:12pt; color:#000000; background-color:#FFFFFF; font-family:Calibri,Arial,Helvetica,sans-serif">
<p>Yes I will revert this ASAP.</p>
<p><br>
</p>
<p>Sorry for the fuss.<br>
</p>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Aaron Ballman <aaron.ballman@gmail.com><br>
<b>Sent:</b> 14 July 2016 19:30:58<br>
<b>To:</b> reviews+D20561+public+af1fea8a731d85ae@reviews.llvm.org<br>
<b>Cc:</b> Roger Ferrer Ibanez; Richard Smith; James Y Knight; Evgenii Stepanov; cfe-commits<br>
<b>Subject:</b> Re: [PATCH] D20561: Warn when taking address of packed member</font>
<div> </div>
</div>
</div>
<font size="2"><span style="font-size:10pt;">
<div class="PlainText">Roger, can you please revert? This seems to have caused some pain for<br>
our users, and it would be good to unblock them while deciding what to<br>
do about the issues.<br>
<br>
~Aaron<br>
<br>
On Thu, Jul 14, 2016 at 2:19 PM, James Y Knight <jyknight@google.com> wrote:<br>
> jyknight added a comment.<br>
><br>
> Regardless, I think this should not have added a new un-disableable error, but instead only a default-on warning.<br>
><br>
> The ""binding reference to packed member" error is firing on some of our code, and even if it's not a false-positive, it should be possible to disable it until the code is modified.<br>
><br>
><br>
> Repository:<br>
> rL LLVM<br>
><br>
> <a href="https://reviews.llvm.org/D20561">https://reviews.llvm.org/D20561</a><br>
><br>
><br>
><br>
<br>
</div>
</span></font>IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use
it for any purpose, or store or copy the information in any medium. Thank you.
</body>
</html>