[PATCH] D20561: Warn when taking address of packed member

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 14 11:30:58 PDT 2016


Roger, can you please revert? This seems to have caused some pain for
our users, and it would be good to unblock them while deciding what to
do about the issues.

~Aaron

On Thu, Jul 14, 2016 at 2:19 PM, James Y Knight <jyknight at google.com> wrote:
> jyknight added a comment.
>
> Regardless, I think this should not have added a new un-disableable error, but instead only a default-on warning.
>
> The ""binding reference to packed member" error is firing on some of our code, and even if it's not a false-positive, it should be possible to disable it until the code is modified.
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D20561
>
>
>


More information about the cfe-commits mailing list