[PATCH] D16041: Change vfs::FileSystem to be managed with std::shared_ptr

[David Blaikie via cfe-commits]

On Sun, Jan 10, 2016 at 11:42 PM, Owen Anderson via cfe-commits <
cfe-commits at lists.llvm.org> wrote:

> resistor created this revision.
> resistor added reviewers: chandlerc, bkramer, klimek.
> resistor added a subscriber: cfe-commits.
> resistor set the repository for this revision to rL LLVM.
> Herald added a subscriber: klimek.
>
> Managing it with IntrusiveRefCntPtr caused the virtual destructor not to
> be called properly.
>

Regardless of the broader discussion on this patch, I'm confused by why
this ^ would be the case. What is it that IntrusiveRefCntPtr is doing
that's causing problems with destruction? (& I'm all for changing this to
non-intrusive smart pointers over intrusive ones anyway, but I'd still like
to understand the extra motivation here)


>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D16041
>
> Files:
>   include/clang/Basic/FileManager.h
>   include/clang/Basic/VirtualFileSystem.h
>   include/clang/Driver/Driver.h
>   include/clang/Frontend/CompilerInstance.h
>   include/clang/Frontend/CompilerInvocation.h
>   include/clang/Tooling/Tooling.h
>   lib/Basic/FileManager.cpp
>   lib/Basic/VirtualFileSystem.cpp
>   lib/Driver/Driver.cpp
>   lib/Format/Format.cpp
>   lib/Frontend/ASTUnit.cpp
>   lib/Frontend/CompilerInstance.cpp
>   lib/Frontend/CompilerInvocation.cpp
>   lib/Frontend/FrontendAction.cpp
>   lib/Index/SimpleFormatContext.h
>   lib/StaticAnalyzer/Frontend/ModelInjector.cpp
>   lib/Tooling/Core/Replacement.cpp
>   lib/Tooling/Tooling.cpp
>   tools/clang-format/ClangFormat.cpp
>   unittests/Basic/VirtualFileSystemTest.cpp
>   unittests/Driver/ToolChainTest.cpp
>   unittests/Lex/PPCallbacksTest.cpp
>   unittests/Tooling/RewriterTestContext.h
>   unittests/Tooling/ToolingTest.cpp
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160111/bfe12f62/attachment.html>