[PATCH] D16041: Change vfs::FileSystem to be managed with std::shared_ptr
David Blaikie via cfe-commits
cfe-commits at lists.llvm.org
Mon Jan 11 08:25:40 PST 2016
On Sun, Jan 10, 2016 at 11:42 PM, Owen Anderson via cfe-commits <
cfe-commits at lists.llvm.org> wrote:
> resistor created this revision.
> resistor added reviewers: chandlerc, bkramer, klimek.
> resistor added a subscriber: cfe-commits.
> resistor set the repository for this revision to rL LLVM.
> Herald added a subscriber: klimek.
> Managing it with IntrusiveRefCntPtr caused the virtual destructor not to
> be called properly.
Regardless of the broader discussion on this patch, I'm confused by why
this ^ would be the case. What is it that IntrusiveRefCntPtr is doing
that's causing problems with destruction? (& I'm all for changing this to
non-intrusive smart pointers over intrusive ones anyway, but I'd still like
to understand the extra motivation here)
> rL LLVM
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the cfe-commits