<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Jan 10, 2016 at 11:42 PM, Owen Anderson via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">resistor created this revision.<br>
resistor added reviewers: chandlerc, bkramer, klimek.<br>
resistor added a subscriber: cfe-commits.<br>
resistor set the repository for this revision to rL LLVM.<br>
Herald added a subscriber: klimek.<br>
<br>
Managing it with IntrusiveRefCntPtr caused the virtual destructor not to be called properly.<br></blockquote><div><br></div><div>Regardless of the broader discussion on this patch, I'm confused by why this ^ would be the case. What is it that IntrusiveRefCntPtr is doing that's causing problems with destruction? (& I'm all for changing this to non-intrusive smart pointers over intrusive ones anyway, but I'd still like to understand the extra motivation here)</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Repository:<br>
  rL LLVM<br>
<br>
<a href="http://reviews.llvm.org/D16041" rel="noreferrer" target="_blank">http://reviews.llvm.org/D16041</a><br>
<br>
Files:<br>
  include/clang/Basic/FileManager.h<br>
  include/clang/Basic/VirtualFileSystem.h<br>
  include/clang/Driver/Driver.h<br>
  include/clang/Frontend/CompilerInstance.h<br>
  include/clang/Frontend/CompilerInvocation.h<br>
  include/clang/Tooling/Tooling.h<br>
  lib/Basic/FileManager.cpp<br>
  lib/Basic/VirtualFileSystem.cpp<br>
  lib/Driver/Driver.cpp<br>
  lib/Format/Format.cpp<br>
  lib/Frontend/ASTUnit.cpp<br>
  lib/Frontend/CompilerInstance.cpp<br>
  lib/Frontend/CompilerInvocation.cpp<br>
  lib/Frontend/FrontendAction.cpp<br>
  lib/Index/SimpleFormatContext.h<br>
  lib/StaticAnalyzer/Frontend/ModelInjector.cpp<br>
  lib/Tooling/Core/Replacement.cpp<br>
  lib/Tooling/Tooling.cpp<br>
  tools/clang-format/ClangFormat.cpp<br>
  unittests/Basic/VirtualFileSystemTest.cpp<br>
  unittests/Driver/ToolChainTest.cpp<br>
  unittests/Lex/PPCallbacksTest.cpp<br>
  unittests/Tooling/RewriterTestContext.h<br>
  unittests/Tooling/ToolingTest.cpp<br>
<br>
<br>_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div><br></div></div>