[PATCH] D14919: Fix IssueHash generation

Gyorgy Orban via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 25 07:28:04 PST 2015


o.gyorgy added a subscriber: o.gyorgy.
o.gyorgy marked an inline comment as done.
o.gyorgy added a comment.

I did not create a test checker for the NormalizeLine error in the patch.
Should I add a test checker for this? Do you have any suggestions
where to put it if required?

GetEnclosingDeclContextSignature already checks for nullptr, this
should have been done in the NormalizeLine function also, but in that
case it is not enough because the Lexer needs the LangOpts.


http://reviews.llvm.org/D14919





More information about the cfe-commits mailing list