[PATCH] D14919: Fix IssueHash generation
Orbán György via cfe-commits
cfe-commits at lists.llvm.org
Wed Nov 25 07:28:02 PST 2015
I did not create a test checker for the NormalizeLine error in the patch.
Should I add a test checker for this? Do you have any suggestions
where to put it if required?
GetEnclosingDeclContextSignature already checks for nullptr, this
should have been done in the NormalizeLine function also, but in that
case it is not enough because the Lexer needs the LangOpts.
On Tue, Nov 24, 2015 at 5:18 PM, Sean Eveson <eveson.sean at gmail.com> wrote:
> seaneveson added a subscriber: seaneveson.
> seaneveson added a comment.
>> If the Decl *D pointer is nullptr the NormalizeLine would crash while getting the LangOptions.
> Do you have a reproducible test case for this?
More information about the cfe-commits