[PATCH] D14919: Fix IssueHash generation

Sean Eveson via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 26 01:49:13 PST 2015

seaneveson added a comment.

In http://reviews.llvm.org/D14919#296597, @o.gyorgy wrote:

> I did not create a test checker for the NormalizeLine error in the patch.
>  Should I add a test checker for this?

I was wondering what sort of source code causes the crash, but I do think it would be good to have a regression test.

> Do you have any suggestions where to put it if required?

Maybe in bug_hash_test.cpp, although I'm not sure its necessary to check the plist output when testing for a crash.


More information about the cfe-commits mailing list