[PATCH] Fix frontend crash related to forward declaration of NSNumber
1101.debian at gmail.com
Mon Feb 16 05:39:35 PST 2015
Not to give you a hard time, but, why are you asking for pre-commit review?
Well, due to first link (obtaining commit access) I got 'commit-after-approval’ access, so just trying to follow the rules.
Anyway, thank you for feedback and useful links.
Software Engineer, https://github.com/AlexDenisov
On 16 Feb 2015 at 14:35:27, hfinkel at anl.gov (hfinkel at anl.gov) wrote:
In http://reviews.llvm.org/D7643#124219, @AlexDenisov wrote:
> It’s a trivial one, but I don’t want to push it without review, though it fixes crash
Not to give you a hard time, but, why are you asking for pre-commit review? It sounds like you consider this to be a fairly-obvious one-line change to fix a crash-on-invalid case (and that is indeed what it looks like). If so, you don't need pre-commit review, so please feel free to commit. If you'd like a pre-commit review anyway, it is helpful to explain your doubts so potential reviews have some idea about what you're unsure, and are aware of any potential complications you're contemplating.
Also, for the future, please upload full-context patches to Phabricator, see: http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface
> Software Engineer, https://github.com/AlexDenisov
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the cfe-commits